Doc: Create guardian.md #4125
Merged
Doc: Create guardian.md #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
doc_create_guardian.md
branch
2 times, most recently
from
8a9882a
to
11b7168
Compare
bruce-riley
force-pushed
the
doc_create_guardian.md
branch
from
11b7168
to
426f7de
Compare
evan-gray
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Overall good, just some nits. Would be good to solidify the language in the Observation Lifecycle section to use
- "message" to refer to the publication from core contract sent by the watcher to the processor
- "observation" to refer to the message hash + signature created in the processor from a message and gossiped
I think I covered the appropriate changes in the comments.
bingyuyap
reviewed
Sep 30, 2024
bingyuyap
reviewed
Sep 30, 2024
bingyuyap
previously approved these changes
Sep 30, 2024
evan-gray
previously approved these changes
Sep 30, 2024
bruce-riley
dismissed stale reviews from evan-gray and bingyuyap
via
09efac8
bingyuyap
previously approved these changes
Sep 30, 2024
panoel
reviewed
Sep 30, 2024
panoel
previously approved these changes
Sep 30, 2024
bruce-riley
force-pushed
the
doc_create_guardian.md
branch
from
09efac8
to
b14776f
Compare
panoel
approved these changes
Sep 30, 2024
evan-gray
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.